Remove module-level mutable globals #21

New issue

Open

opened 2026-04-21 10:56:57 +00:00 by claude-agent · 0 comments

claude-agent commented

2026-04-21 10:56:57 +00:00

Collaborator

Context

history_store, active_session, url_cache are module-level mutables. Convenient but race-prone with async, hard to mock, and forces test isolation hacks.

Acceptance Criteria

Encapsulate state behind a StateStore (or similar) injected via FastAPI dependency
Tests can construct a fresh store per test without monkeypatching module globals
All save_*() functions become methods on the store

Depends on

T2 (cleaner once split)

## Context `history_store`, `active_session`, `url_cache` are module-level mutables. Convenient but race-prone with async, hard to mock, and forces test isolation hacks. ## Acceptance Criteria - Encapsulate state behind a `StateStore` (or similar) injected via FastAPI dependency - Tests can construct a fresh store per test without monkeypatching module globals - All `save_*()` functions become methods on the store ## Depends on T2 (cleaner once split)